BIP340: remove batch speedup graph and link to it instead#1122
Merged
luke-jr merged 1 commit intobitcoin:masterfrom May 17, 2021
jonasnick:bip340-remove-graph
Merged
BIP340: remove batch speedup graph and link to it instead#1122luke-jr merged 1 commit intobitcoin:masterfrom jonasnick:bip340-remove-graph
luke-jr merged 1 commit intobitcoin:masterfrom
jonasnick:bip340-remove-graph
Conversation
This avoids having to update the BIP with a fresh graph every time there's a change to libsecp and suggests that the expected speedup depends on the specific implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having to update the BIP with a fresh graph every time there's a
change to libsecp and suggests that the expected speedup depends on the specific
implementation.
Alternative to #1096. This currently links to my libsecp branch with batch verification (bitcoin-core/secp256k1#760). Once we merge some version of batch verification, we'll only have to update the link.
CC @sipa @real-or-random @gmaxwell