Skip to content

add ECMULT_GEN_PREC_BITS to basic_config.h#916

Closed
voisine wants to merge 1 commit intobitcoin-core:masterfrom
voisine:patch-1
Closed

add ECMULT_GEN_PREC_BITS to basic_config.h#916
voisine wants to merge 1 commit intobitcoin-core:masterfrom
voisine:patch-1

Conversation

@voisine
Copy link
Copy Markdown
Contributor

@voisine voisine commented Apr 10, 2021

set ECMULT_GEN_PREC_BITS to the "auto" value of 4 in basic_config.h, so libsecp can be used without autoconf

set ECMULT_GEN_PREC_BITS to the "auto" value of 4 in basic_config.h, so libsecp can be used without autoconf
@real-or-random
Copy link
Copy Markdown
Contributor

Thanks for the PR, this is indeed a bug! However, fixing it requires some more cleanup (see CI failures).

I'm currently playing around with some options. I should have something ready by tomorrow.

@real-or-random
Copy link
Copy Markdown
Contributor

By the way, how do you use this library without autoconf? Do you simply #include it or do you build it and then link it? In either case I'd we interested in the exact method, e.g.: How do you define your config? Do you include basic-config.h? What's the command line?

This could help us towards #622.

@voisine
Copy link
Copy Markdown
Contributor Author

voisine commented Apr 11, 2021

Thank you. Currently I just #include basic_config.h and then the appropriate libsecp implementations, but I eventually plan to add the source files to an external build system other than “make”

@voisine
Copy link
Copy Markdown
Contributor Author

voisine commented Apr 11, 2021

Specifically I want to be able to build using Xcode on a clean OS X install without installing additional build tools like autoconf.

@jonasnick
Copy link
Copy Markdown
Contributor

Superseded by #918 (merged)

@jonasnick jonasnick closed this Apr 19, 2021
@voisine
Copy link
Copy Markdown
Contributor Author

voisine commented Apr 19, 2021

Excellent. My commit even managed to survive into the final merge. Thank you.

@voisine voisine deleted the patch-1 branch December 1, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants