ctime_test: move context randomization test to the end#894
Merged
jonasnick merged 1 commit intobitcoin-core:masterfrom Feb 22, 2021
Merged
ctime_test: move context randomization test to the end#894jonasnick merged 1 commit intobitcoin-core:masterfrom
jonasnick merged 1 commit intobitcoin-core:masterfrom
Conversation
Contributor
|
ah, indeed the comment said it needed to be last. :) Did you look into why it wasn't causing failures with the schnorrsig test? |
real-or-random
approved these changes
Feb 5, 2021
Contributor
Author
The reason is that in |
real-or-random
approved these changes
Feb 5, 2021
Contributor
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
ACK 7d3497c diff looks good
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 23, 2021
Summary: the idea is to have a markdown convention that will link to the two repos we already backport from and include the bitcoin-core/gui repo after this diff I establish the following convention: summary text in the format LOWERCASE_SUPPORTED_REPO_PREFIX#PR_NUMBER will be replaced with a link to the appropriate PR if LOWERCASE_SUPPORTED_REPO_PREFIX is in the relevant dictionary in server.py examples: core#17234 should replace to [[bitcoin/bitcoin#17234 | core#17234]] core-gui#9 to [[bitcoin-core/gui#9 | core-gui#9]] and secp256k1#894 to [[bitcoin-core/secp256k1#894 | secp256k1#894]] Test Plan: pytest Reviewers: Fabien, #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9258
jesseposner
added a commit
to jesseposner/secp256k1-zkp
that referenced
this pull request
Mar 5, 2021
This commit adds test coverage including Travis scripts, Valgrind constant time tests for secret data, API tests, nonce function tests, and test vectors from the spec. This commit includes changes from bitcoin-core/secp256k1#894 that fix a bug upstream.
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Apr 8, 2021
Summary: ``` I noticed this while reviewing BlockstreamResearch/secp256k1-zkp#117 and finding some seemingly unnecessary VALGRIND_MAKE_MEM_DEFINED that I couldn't remove until I saw the bug. ``` Backport of [[bitcoin-core/secp256k1#894 | secp256k1#894]] Test Plan: ninja check-secp256k1 libtool --mode=execute valgrind ./valgrind_ctime_test Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9389
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Apr 9, 2021
Summary: ``` I noticed this while reviewing BlockstreamResearch/secp256k1-zkp#117 and finding some seemingly unnecessary VALGRIND_MAKE_MEM_DEFINED that I couldn't remove until I saw the bug. ``` Backport of [[bitcoin-core/secp256k1#894 | secp256k1#894]] Test Plan: ninja check-secp256k1 libtool --mode=execute valgrind ./valgrind_ctime_test Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while reviewing BlockstreamResearch/secp256k1-zkp#117 and finding some seemingly unnecessary
VALGRIND_MAKE_MEM_DEFINEDthat I couldn't remove until I saw the bug.