Add basic usage information on README [skip ci]#673
Closed
kroggen wants to merge 1 commit intobitcoin-core:masterfrom
kroggen:patch-1
Closed
Add basic usage information on README [skip ci]#673kroggen wants to merge 1 commit intobitcoin-core:masterfrom kroggen:patch-1
kroggen wants to merge 1 commit intobitcoin-core:masterfrom
kroggen:patch-1
Conversation
Author
|
What about changing "key generation" on README to "public key generation"? |
jonasnick
reviewed
Oct 11, 2019
Contributor
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
I'm in favor of adding a Usage section, but the bullet points in this PR seem a bit out of place. Much more helpful would be to provide examples for pubkey generation, signing and verification and add a link to the include files for the documentation.
Contributor
|
Closing in favor of #748. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may not be so good documentation, but at least it is a start. Feel comfortable to fix it.
#672