Improve checks for scalar _get_bits methods#1845
Open
peterdettman wants to merge 1 commit intobitcoin-core:masterfrom
Open
Improve checks for scalar _get_bits methods#1845peterdettman wants to merge 1 commit intobitcoin-core:masterfrom
peterdettman wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the
VERIFY_CHECKs in all_scalar_get_bits_limb32and_scalar_get_bits_varmethods.The initial prompt was noticing that scalar_4x64_impl/
secp256k1_scalar_get_bits_limb32was not restricting to 32-bit limbs correctly. Then missing range checks foroffsetwere added and all such checks rewritten to avoid overflow.With these changes, the _low and _4x64 impls of
_get_bits_varcan no longer forward to_get_bits_limb32, so those calls were inlined instead.