Schnorr (Incremental) Half Aggregation#1566
Open
fjahr wants to merge 1 commit intobitcoin-core:masterfrom
Open
Schnorr (Incremental) Half Aggregation#1566fjahr wants to merge 1 commit intobitcoin-core:masterfrom
fjahr wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
jjones3695
approved these changes
Jul 16, 2024
fjahr
force-pushed
the
2024-07-half-agg
branch
2 times, most recently
from
6218bda to
0effa49
Compare
Contributor
Author
|
Rebased on the musig changes and added the compile options for cmake |
fjahr
force-pushed
the
2024-07-half-agg
branch
4 times, most recently
from
31c6b5d to
db91a39
Compare
fjahr
force-pushed
the
2024-07-half-agg
branch
from
db91a39 to
bcd6b9c
Compare
fjahr
force-pushed
the
2024-07-half-agg
branch
from
bcd6b9c to
19da8a9
Compare
Contributor
Author
|
Rebased to take into account the latest changes to cmake, CI and test framework. Also squashed the commit since maintaining them was annoying and there wasn't really a good reason for them. It was more of a crutch for me while I was taking my first steps here. |
This includes addressing nits from the halfagg PR in secp-zkp: - we may want to add a header to the include file that links to the BIP - there's still a mention of aggsig_size - we may want to move aggregate before inc_aggregate - we should mention expected size of input aggsig array in_aggregate - 'Should be aggsig_len = 32*(n+1)' -> 'Must be' Co-authored-by: Benedikt <crypto@benedikt-wagner.dev>
fjahr
force-pushed
the
2024-07-half-agg
branch
from
19da8a9 to
ccc826d
Compare
Jonatanc05
reviewed
Feb 22, 2026
| * Args: ctx: a secp256k1 context object. | ||
| * In: pubkeys: Array of n many x-only public keys. Can only be NULL if n is 0. | ||
| * msgs32: Array of n many 32-byte messages. Can only be NULL if n is 0. | ||
| * n: number of signatures to that have been aggregated. |
There was a problem hiding this comment.
Suggested change
| * n: number of signatures to that have been aggregated. | |
| * n: number of signatures that have been aggregated. |
Contributor
Author
There was a problem hiding this comment.
Thanks, I will address it the next time I will push an update!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports over the work from b-wagn in BlockstreamResearch/secp256k1-zkp#261
In the second commit I have addressed the follow-ups though I was not always sure if I understood them correctly since they weren't inline. Please let me know if they are correct then I can squash the commit here and open it as a PR on zkp.