Remove secp256k1_fe_const_b#1282
Closed
roconnor-blockstream wants to merge 1 commit intobitcoin-core:masterfrom
Closed
Remove secp256k1_fe_const_b#1282roconnor-blockstream wants to merge 1 commit intobitcoin-core:masterfrom
roconnor-blockstream wants to merge 1 commit intobitcoin-core:masterfrom
Conversation
It's last use was eliminated in bitcoin-core#1217.
Contributor
It would appear that #1118 added another use back (which can easily be converted to |
Contributor
By the way, this shows that it's a good idea to remove |
Contributor
|
See #1283 for a fix. |
real-or-random
added a commit
that referenced
this pull request
Apr 21, 2023
69e1ec0 Get rid of secp256k1_fe_const_b (Pieter Wuille) Pull request description: Replaces #1282. Its only remaining use is in a test introduced in #1118, and it is easily replaced by the new `secp256k1_fe_add_int` from #1217. ACKs for top commit: real-or-random: utACK 69e1ec0 Tree-SHA512: 6ada192e0643fc5326198b60f019a5081444f9ba0a5b8ba6236f2a526829d8e5e479556600a604d9bc96c7ba86e3aab813f93c66679287d2135e95a2b75f5d3e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's last use was eliminated in #1217.