[Minor fix] : Removed extra checks from isAdmin variable in Footer.jsx

[rautniraj]

We dont need these two checks : currentUser && currentUser.role
We can handle this in a good way : currentUser?.role?.name === 'Administrator'

[rautniraj]

What i observe, we should also let super admin to view version tag in footer. My suggestion

const isAdmin = currentUser?.role?.name === 'Administrator' || currentUser?.role?.name === 'SuperAdmin';

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[farhatahmad]

What i observe, we should also let super admin to view version tag in footer. My suggestion
const isAdmin = currentUser?.role?.name === 'Administrator' || currentUser?.role?.name === 'SuperAdmin'

Agreed - can you make this change?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rautniraj]

Its done now. In Footer.jsx + SharedAccess.jsx element i have modified isAdmin check to include SuperAdmin also. These were the two places where isAdmin was being checked.

Important

Please share your view on my very old PR #5951 . Suggested changes will improve the UI and application logic.

[farhatahmad]

Was having issues merging this, so I created a new PR