Skip to content

fix(migrations): Set user password_digest only if it was received #5763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danimo wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

fix(migrations): Set user password_digest only if it was received #5763

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
699badb
fix(migrations): Set user password_digest only if it was received
danimo Mar 28, 2024
8740ffb
Merge branch 'master' into fix/password_digest_fix
danimo Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/controllers/api/v1/migrations/external_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,13 @@ def create_user

return render_error(status: :bad_request, errors: user&.errors&.to_a) unless user.save

user.password_digest = user_hash[:provider] == 'greenlight' ? user_hash[:password_digest] : nil
user.save(validations: false)
if user_hash[:provider] != 'greenlight'
user.password_digest = nil
user.save(validations: false)
elsif user_hash[:password_digest]
user.password_digest = user_hash[:password_digest]
user.save(validations: false)
end

render_data status: :created
end
Expand Down