-
Notifications
You must be signed in to change notification settings - Fork 200
[ENH] BEP047 - Add audio/video recordings to behavioral experiments #2231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 6 commits
ee69b4c
ea2e5d1
e1d95e8
ffccafc
4707a33
38310aa
fa98d09
8884985
827e7d9
7cacffd
9b262a3
7bc990a
e8a8bf3
3ee2c6c
826e25a
00e3e26
25f65e1
bf00bc6
540a1e7
fc019ae
d7b1270
1c06c08
e7a2332
0b2d464
4245b5d
aead0a4
3756616
272516c
8e50668
0704e4a
5df5916
b11d981
ff8c605
83d3208
2f3d1d4
98eea5e
bddeb17
7bb98a9
877beeb
cc41d49
1b1da59
029deac
63a4bf7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -807,6 +807,13 @@ Descriptors: | |
| - type: array | ||
| items: | ||
| type: string | ||
| Device: | ||
| name: Device | ||
| display_name: Device | ||
| description: | | ||
| Free-form description of the device used to record the data | ||
| (for example, `"iPhone 12"`, `"Canon EOS R5"`). | ||
| type: string | ||
| DeviceSerialNumber: | ||
| name: DeviceSerialNumber | ||
| display_name: Device Serial Number | ||
|
|
@@ -2990,6 +2997,12 @@ RecordingDuration: | |
| Length of the recording in seconds (for example, `3600`). | ||
| type: number | ||
| unit: s | ||
| RecordingSetupName: | ||
| name: RecordingSetupName | ||
| display_name: Recording Setup Name | ||
| description: | | ||
| Custom name of the recording setup. | ||
| type: string | ||
|
bendichter marked this conversation as resolved.
Outdated
|
||
| RecordingType: | ||
| name: RecordingType | ||
| display_name: Recording Type | ||
|
|
@@ -3789,6 +3802,13 @@ SubjectArtefactDescription: | |
| If this field is set to `"n/a"`, it will be interpreted as absence of major | ||
| source of artifacts except cardiac and blinks. | ||
| type: string | ||
| SupplementarySignals: | ||
| name: SupplementarySignals | ||
| display_name: Supplementary Signals | ||
| description: | | ||
| Description of the supplementary signal (additional modalities) recorded | ||
| in parallel and are also stored in the data file. | ||
| type: string | ||
|
bendichter marked this conversation as resolved.
Outdated
|
||
| TablePosition: | ||
| name: TablePosition | ||
| display_name: Table Position | ||
|
|
@@ -4197,3 +4217,63 @@ iEEGReference: | |
| this field should have a general description and the channel specific | ||
| reference should be defined in the `channels.tsv` file. | ||
| type: string | ||
|
|
||
| AudioChannelCount: | ||
| name: AudioChannelCount | ||
| display_name: Audio Channel Count | ||
| description: | | ||
| Number of audio channels in the recording (for example, `2` for stereo). | ||
| type: integer | ||
| minimum: 1 | ||
|
|
||
| AudioDuration: | ||
| name: AudioDuration | ||
| display_name: Audio Duration | ||
| description: | | ||
| Duration of the audio recording in seconds. | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: s | ||
|
|
||
| AudioSampleRate: | ||
| name: AudioSampleRate | ||
| display_name: Audio Sample Rate | ||
| description: | | ||
| Sample rate of the audio recording in Hertz (for example, `44100`). | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: Hz | ||
|
|
||
| Duration: | ||
| name: Duration | ||
| display_name: Duration | ||
| description: | | ||
| Total duration of the audio or video recording in seconds. | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: s | ||
|
|
||
| FrameRate: | ||
| name: FrameRate | ||
| display_name: Frame Rate | ||
| description: | | ||
| Frame rate of the video recording in frames per second (for example, `30.0`). | ||
| type: number | ||
| exclusiveMinimum: 0 | ||
| unit: Hz | ||
|
|
||
| Height: | ||
| name: Height | ||
| display_name: Video Height | ||
| description: | | ||
| Height of the video in pixels (for example, `1920`). | ||
|
bendichter marked this conversation as resolved.
Outdated
bendichter marked this conversation as resolved.
Outdated
|
||
| type: integer | ||
| minimum: 1 | ||
|
|
||
| Width: | ||
| name: Width | ||
| display_name: Video Width | ||
| description: | | ||
| Width of the video in pixels (for example, `1080`). | ||
|
bendichter marked this conversation as resolved.
Outdated
|
||
| type: integer | ||
| minimum: 1 | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be quite valuable to expose at least some details on the underlying codec(s) used for audio/video within the files, so e.g. we could assess if e.g. browser would play it etc?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK but let's try to make it as easy as possible to acquire and standardize this data. Can we just use something that is output by FFMPEG? Do we want to make codec information required?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Exactly what was proposed in #2367 (comment), I would start with that PR maybe
I believe we have reached a positive consensus; this is critical and highly valuable information |
||
Uh oh!
There was an error while loading. Please reload this page.