Skip to content

fix(rollout): clear stale LLM trajectory on rollout reuse #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhiheng-yang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rollout): clear stale LLM trajectory on rollout reuse #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/benchflow/rollout/_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,7 @@ def _init_rollout(
rollout_dir.mkdir(parents=True, exist_ok=True)
for subdir in ("agent", "verifier", "artifacts", "trajectory"):
(rollout_dir / subdir).mkdir(exist_ok=True)
(rollout_dir / "trajectory" / "llm_trajectory.jsonl").unlink(missing_ok=True)
return task, rollout_dir, rollout_paths, started_at, job_name, rollout_name


Expand Down
21 changes: 21 additions & 0 deletions tests/test_sdk_internals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,27 @@ def test_custom_rollout_name(self, task_dir, tmp_path):
)
assert rollout_name == "custom-trial"

def test_reused_rollout_drops_previous_llm_trajectory(self, task_dir, tmp_path):
"""Drops a prior provider trajectory when a reused rollout has no new one."""
jobs_dir = tmp_path / "jobs"
_, rollout_dir, _, _, _, _ = self._init(
task_dir,
job_name="job",
rollout_name="rollout",
jobs_dir=jobs_dir,
)
trajectory = rollout_dir / "trajectory" / "llm_trajectory.jsonl"
trajectory.write_text('{"completion":"stale"}\n')

self._init(
task_dir,
job_name="job",
rollout_name="rollout",
jobs_dir=jobs_dir,
)

assert not trajectory.exists()

def test_started_at_is_datetime(self, task_dir, tmp_path):
_, _, _, started_at, _, _ = self._init(task_dir, jobs_dir=tmp_path / "jobs")
assert isinstance(started_at, datetime)
Expand Down