Branch - Eduardo Yucho Yamaguti [Programador Plêno] - #45
Open
EduardoYucho wants to merge 2 commits into
Open
Conversation
douglashiura
suggested changes
Oct 13, 2023
| this.emptyCell = cell; | ||
| }); | ||
| Optional<GameVertex> minCell = this.cells.stream() | ||
| .min(Comparator.comparing(GameVertex::getValue)); |
Contributor
There was a problem hiding this comment.
Boa Tarde,
Objetos devem trocar mensagens.
O objetivo é uso de POO, o uso de programação funcional atrapalha na coesão.
Att.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Melhorias na Abstração e POO Pura:
Refatorei as classes para seguir princípios de POO de forma mais pura.
Renomeei classes para representar os elementos de forma mais clara.
Redução de Código:
Simplifiquei a lógica de busca de adjacências e remoção de células vazias.
Limpei o código de partes desnecessárias e redundantes.
Experiência do Usuário:
Corrigi erros de lógica na exibição de mensagens.
Simplifiquei a lógica de atualização do tabuleiro e verificação de jogo completo.
Corrigi um erro que ocorria quando o espaço vazio era clicado.
Espero que essas mudanças tornem o código mais robusto, legível e alinhado com os princípios de programação orientada a objetos.