Conversation
It was NOT_IMPL, so Path.GetTempPath returned an empty string on Linux and macOS and every caller composed a path at the filesystem root. corlib's own FileTests.WriteAll_PropagatesResult is one of them, and could not have passed on either platform. The temp directory was already known to this file: BfpFile_GetTempFileName sits directly below and hardcodes /tmp. This reads TMPDIR first, as POSIX tools do, falls back to the same /tmp, and returns it with a trailing separator to match what the Windows implementation returns from GetTempPathW.
Collaborator
|
You got pipped by this #2492 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was NOT_IMPL, so Path.GetTempPath returned an empty string on Linux and macOS and every caller composed a path at the filesystem root. corlib's own FileTests.WriteAll_PropagatesResult is one of them, and could not have passed on either platform.
The temp directory was already known to this file: BfpFile_GetTempFileName sits directly below and hardcodes /tmp. This reads TMPDIR first, as POSIX tools do, falls back to the same /tmp, and returns it with a trailing separator to match what the Windows implementation returns from GetTempPathW.