corlib: handle comptime in the TypeInstance.GetMethod(int) override - #2496
Merged
Merged
Conversation
An extension overrides GetMethod(int) with an implementation that indexes the runtime method table, which replaces the comptime branch on the base declaration rather than adding to it. At comptime mMethodDataCount is 0, so every index answers NoResults for a type whose methods are all present: Comptime_GetMethodCount reports 8 for a class the override finds nothing in, and the native Comptime_GetMethod returns a valid handle for each of them. Restores the comptime path in the override, so an IComptimeTypeApply attribute can walk a type's methods by index. Adds Comptime.ComptimeMethodLookup over a class with two named static methods.
jayrulez
force-pushed
the
fix/comptime-getmethod-index
branch
from
September 5, 2026 18:19
8ccbba6 to
73293e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extension overrides GetMethod(int) with an implementation that indexes the runtime method table, which replaces the comptime branch on the base declaration rather than adding to it. At comptime mMethodDataCount is 0, so every index is NoResults for a type whose methods are all present.
Restores the comptime path in the override, so an IComptimeTypeApply attribute can walk a type's methods by index.
Test:
Adds Comptime.ComptimeMethodLookup over a class with two named static methods.
Note: The issue was debugged by and the fix created by Claude.