Repository navigation
Conversation
Contributor
Author
|
I think there may be a bigger or at least different change to SIMD types and intrinsics that is needed. When trying to compute sqrt for a float4 with SIMD, you can either :
I'll close this PR as this fixes only part of the problem and does not address it properly. |
Collaborator
|
It's probably good to note here that I would probably SIMD support currently as "proof of concept". I believe that auto-vectorization should work about the same as in Clang, however. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2427 by adding lowered types for the vector types defined in Numerics. I don't know if this is the right approach but it seems to work in my testing.