fix(samba): deleteExpiredShares ticker 接受 ctx 并接入 lifecycle#253
Open
fix(samba): deleteExpiredShares ticker 接受 ctx 并接入 lifecycle#253
Conversation
(*samba).deleteExpiredShares started a goroutine that ranged
forever over a 5-minute ticker, calling K8s List/Delete with
context.Background() each tick. The loop wasn't tied to any
shutdown signal:
- After SIGTERM the goroutine kept polling K8s and issuing
Delete calls during the same window other subsystems were
tearing down.
- The cleanup binary's lifecycle coordinator never knew about it.
Add cancelCleanup / cleanupDone fields and turn the loop into a
standard select { case <-ctx.Done(): return; case <-tick }
shape. Replace the inner context.Background() calls with the
loop's ctx so the in-flight K8s call also gets cancelled.
Expose samba.Stop(ctx) and register a "samba-cleanup" lifecycle
hook in cmd/samba/main.go (the only binary that calls
SambaService.Start() and therefore deleteExpiredShares).
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
`pkg/samba/samba.go` 的 `(*samba).deleteExpiredShares`:
```go
go func() {
for range time.NewTicker(5 * time.Minute).C {
// ... List + Delete 都用 context.Background()
}
}()
```
SIGTERM 之后 5 分钟内还可能发出 Delete 请求,与其它子系统的关闭交叉。
改动
验证方式
Made with Cursor