fix(tasks): DownloadFromFiles 把任务 ctx 串到 HTTP 请求#235
Merged
lovehunter9 merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
Both http.NewRequest calls in DownloadFromFiles built request objects with no context. Cancellation was only observed at the inner read loop (via t.isCancel()), so a slow / stuck dial or response-header phase could keep the HTTP roundtrip alive long after Pause/Cancel fired and well past the task's intended lifetime. Switch both to http.NewRequestWithContext(t.ctx, ...) so transport cancellation kicks in immediately when the task is cancelled. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
`pkg/tasks/task_paste_download.go` 的两次 `http.NewRequest`(一次拉文件树、一次拉单个文件)都没带任何 context。任务被 Pause / Cancel 时只有读循环里调用了 `t.isCancel()` 检测,但:
改动
把两处 `http.NewRequest("GET", ...)` 改为 `http.NewRequestWithContext(t.ctx, "GET", ...)`。`net/http` Transport 看到 ctx cancel 会立刻终止 dial / 读 header / 读 body,cancellation 立刻生效。
验证方式
Made with Cursor