Repository navigation
Portal extension zone hot reload fix - #4909
Merged
Merged
Conversation
…/storage-name-validation
…/portal-extension-hot-reload
…/portal-extension-hot-reload # Conflicts: # cli/cli/Services/BeamoLocalSystem.cs # cli/cli/Services/DeploymentService.cs
Contributor
|
Lightbeam link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets zone-scoped microservices send server events, so portal extensions hot-reload in zones too. Until now, zone portal extensions skipped the hot-reload push because the only notifications API was realm-scoped. This splits the server-event methods into a new interface that both realm and zone containers can register.
Changes
IMicroserviceServerNotificationsApiinterface with theNotifyServeroverloads, not marked[RealmScoped]IMicroserviceNotificationsApi(still[RealmScoped]) now extends it;NotifyPlayer/NotifyGamestay realm-onlyMicroserviceServerNotificationApibase class added;MicroserviceNotificationApiderives from itIMicroserviceServerNotificationsApiforwards to the existing realm notifications API (publishes oncid.pid)MicroserviceServerNotificationApion the zone socket (publishes oncid.zid); it builds its own requester so it also resolves at the zone root, where there is noRequestContextZoneServicesImplremoves the zone notifier before applying the realm SDK inAssumeRealmscopesPortalExtensionObserver/BeamoLocalSystem_PortalExtensionuse the new interface for both scopes; zone TODOs removedMicroserviceNotificationApi