Skip to content

Issue/login bug - #4635

Merged
cdhanna merged 2 commits into
mainfrom
issue/login-bug
Jun 1, 2026
Merged

cdhanna merged 2 commits into
mainfrom
issue/login-bug

Conversation

@cdhanna

@cdhanna cdhanna commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Ticket

https://disruptorbeam.atlassian.net/browse/BEAM-XXXX

Brief Description

Put description here

Checklist

  • Have you added appropriate text to the CHANGELOG.md files?

Add those to list or remove the list below altogether:

Notes

When you are merging a feature branch into main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging from main to staging, or staging to production, please use a regular merge commit.

Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?

Copilot AI review requested due to automatic review settings June 1, 2026 18:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses an Editor-side CLI “login bug” by adjusting how Unity editor commands talk to the local Beam CLI web server and by hardening UI rendering against missing assets.

Changes:

  • Prevent DrawLogoBanner from dereferencing a missing logo texture.
  • Switch Beam web CLI execution to use a per-command HttpClient to avoid stale/poisoned pooled localhost connections (notably on Windows).
  • Track the active run Promise so Cancel() can mark cancellation errors as “observed” (reducing uncaught-promise noise).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
client/Packages/com.beamable/Editor/UI/BeamGUI/BeamGUI_LogoBanner.cs Adds a null/invalid-texture guard before using logo dimensions.
client/Packages/com.beamable/Editor/BeamCli/BeamWebCommand.cs Reworks HttpClient lifetime to be per-run and adjusts cancellation/promise handling for Beam web CLI commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Lightbeam link

@cdhanna
cdhanna merged commit 49bdf13 into main Jun 1, 2026
30 checks passed
@cdhanna
cdhanna deleted the issue/login-bug branch June 1, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants