Repository navigation
Issue/login bug - #4635
Merged
Merged
Issue/login bug#4635
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an Editor-side CLI “login bug” by adjusting how Unity editor commands talk to the local Beam CLI web server and by hardening UI rendering against missing assets.
Changes:
- Prevent
DrawLogoBannerfrom dereferencing a missing logo texture. - Switch Beam web CLI execution to use a per-command
HttpClientto avoid stale/poisoned pooled localhost connections (notably on Windows). - Track the active run
PromisesoCancel()can mark cancellation errors as “observed” (reducing uncaught-promise noise).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/Packages/com.beamable/Editor/UI/BeamGUI/BeamGUI_LogoBanner.cs | Adds a null/invalid-texture guard before using logo dimensions. |
| client/Packages/com.beamable/Editor/BeamCli/BeamWebCommand.cs | Reworks HttpClient lifetime to be per-run and adjusts cancellation/promise handling for Beam web CLI commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Lightbeam link |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://disruptorbeam.atlassian.net/browse/BEAM-XXXX
Brief Description
Checklist
Add those to list or remove the list below altogether:
Notes
When you are merging a feature branch into
main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging frommaintostaging, orstagingtoproduction, please use a regular merge commit.Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?