Skip to content

use better null check - #4627

Merged
cdhanna merged 1 commit into
mainfrom
issue/texture-null-issue
May 28, 2026
Merged

cdhanna merged 1 commit into
mainfrom
issue/texture-null-issue

Conversation

@cdhanna

@cdhanna cdhanna commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Ticket

https://disruptorbeam.atlassian.net/browse/BEAM-XXXX

Brief Description

Put description here

Checklist

  • Have you added appropriate text to the CHANGELOG.md files?

Add those to list or remove the list below altogether:

Notes

When you are merging a feature branch into main, please squash merge and make sure the final commit contains any relevent JIRA ticket number. If you are merging from main to staging, or staging to production, please use a regular merge commit.

Does this introduce tech-debt? If so, have you added an entry to the Tech-debt document?

Copilot AI review requested due to automatic review settings May 28, 2026 14:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Unity editor icon-loading code to use UnityEngine.Object-style existence checks (if (!texture)) instead of explicit null comparisons when caching icon/texture references.

Changes:

  • Replaced == null checks with !<Texture> checks for cached Texture icon fields in LoadUnityIcons.
  • Replaced == null checks with !<Texture> checks for cached Texture art/icon fields in LoadNonConfigurableIcons.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

Lightbeam link

@cdhanna
cdhanna merged commit b157e08 into main May 28, 2026
27 of 29 checks passed
@cdhanna
cdhanna deleted the issue/texture-null-issue branch May 28, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants