Skip to content

Feature/dbc22 6929#1414

Draft
bcgov-brwang wants to merge 3 commits into
mainfrom
feature/DBC22-6929
Draft

Feature/dbc22 6929#1414
bcgov-brwang wants to merge 3 commits into
mainfrom
feature/DBC22-6929

Conversation

@bcgov-brwang

@bcgov-brwang bcgov-brwang commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

📝 Submitter

🔗 JIRA Ticket


✅ Quality Assurance & Requirements

  • Requirements Met: I have confirmed that all acceptance criteria from the JIRA ticket are fulfilled.
  • Tested desktop in local or dev envs
  • Tested mobile in local or dev envs
  • Ran unit tests locally
  • SonarCloud: I have verified that the SonarCloud analysis is clean/passing for this branch.

⚙️ Configuration & Environment

  • New Env Variables: Does this PR require new environment variables? (Yes/No)

    If yes, please list them here and ensure they are added to secret manager, the .env.example. and the Vault by an STA.

🧪 How to Test (if required)

  1. Deploy to dev.
  2. Go to https://dev.drivebc.ca/drivebc-admin/.
  3. Check the "Local weather station" value for a camera.
  4. Go to camera control panel, update the "Weather Station:" for that camera.
  5. Go to https://dev.drivebc.ca/drivebc-admin/.
  6. Verify camera "Local weather station" was updated within a min.
  7. For this requirement logged in the ticket "If ID exists in cam control panel BUT Does not exist as code in the current weathers table, Log the fact there is no match when running the job and don’t make a link]", which is not neccesary because the camera ids are filtered based on what cameras we have in DBC database already when updating cameras in DBC database.
  8. Verify frontend cameras does not have local weather link if camera control panel does not set it up.
  9. Verify frontend cameras does have local weather link same as the weather station that camera control panel set up.

🔍 Reviewer Checklist

  • Reviewed code for logic and cleanliness
  • Re-tested desktop/mobile in local or dev envs
  • Verified no new console warnings/errors
  • Confirmed that any new env variables are understood/documented

DBC22-6929: pull local weather station code to current weather 2

DBC22-6929: deleted local weather link if code does not exist in ccp
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant