[FutariSousa]フタリソウサの判定コマンドに目標値変更とスペシャル値追加の機能を追加#875
Merged
Conversation
- DT/ASコマンドの末尾に >=n で目標値を変更 - [n,m] でスペシャル値を指定できる機能
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
==========================================
+ Coverage 95.92% 96.49% +0.57%
==========================================
Files 382 429 +47
Lines 22674 24931 +2257
Branches 6036 6699 +663
==========================================
+ Hits 21749 24058 +2309
+ Misses 925 873 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ysakasin
requested changes
Apr 23, 2026
|
|
||
| def eval_game_system_specific_command(command) | ||
| if (m = /^(\d+)?DT(?:6)?$/i.match(command)) | ||
| if (m = /^(\d+)?DT(?:6)?(?:>=(\d+))?(?:\[([0-9,]+)\])?$/i.match(command)) |
Member
There was a problem hiding this comment.
追加された分のパースが厳密性に欠けるので、/\[\d+(,\d+)?\]/ のような正規表現にした方が良さそうです。
- スペシャル値 `[n,m...]` のパース処理（正規表現）が意図しない入力（カンマのみ、連続するカンマなど）にマッチしてしまう問題を修正 - 3つ以上のスペシャル値指定にも対応できるよう `(\d+(?:,\d+)*)` に変更 - 関連するテストケースを追加・修正
Contributor
Author
|
ご指摘ありがとうございます。修正しました。 |
ysakasin
approved these changes
May 12, 2026
Member
|
@Aimsot ありがとうございます。マージしました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
いつもお世話になってます。
今回はフタリソウサの一部アクションで目標値の変更や、スペシャル値の追加を行うものがあるので追加しました。
追加カスタムコマンド
確認よろしくお願いします。