WS-2469: Add live pulse to most read page rank.#13909
WS-2469: Add live pulse to most read page rank.#13909shayneahchoon wants to merge 7 commits intolatestfrom
Conversation
| }; | ||
|
|
||
| const clickTrackerHandler = useClickTrackerHandler(eventTrackingDataExtended); | ||
| const isLiveLink = href.includes('live'); |
There was a problem hiding this comment.
I see there is a back-end PR to add an isLive prop to the response. Will that be used here instead?
There was a problem hiding this comment.
Heya, I'm going to can the PR you've mentioned. I drafted it upon waiting for a reply from product. Neil is happy for our current changes to go forward as is without needing to check the expiry date.
There was a problem hiding this comment.
+1 on this. At the moment the logic suggests that if a live page was no longer being updated (hence, no longer live), the label and icon will still show.
I imagine we don't need this calculated down to a tee (e.g. with polling to check if an article is still live), but it seems like the other PR checks the start/end times of an article being live so that seems preferable.
3 participants
Resolves JIRA: https://bbc.atlassian.net/browse/WS-2469
Summary
Adds live pulse to live most read ranks:
Code changes
Testing
Useful Links