Skip to content

Add VJ full width scrolly component #13669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Chris-Kay wants to merge 2 commits into
base: latest
Choose a base branch
from
Draft

Add VJ full width scrolly component #13669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df7e0f0
Add VJ full width scrolly component
Chris-Kay Feb 2, 2026
b1ce44b
More styling
Chris-Kay Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/app/components/Embeds/EmbedHtml/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const EmbedHtml = ({ embeddableContent }: PropsWithChildren<Props>) => {
if (!embeddableContent) return null;

if (isLite) return null;

console.log('!!!!', embeddableContent)
// TODO: Remove this logic after the US Elections
const isUSElectionBanner = embeddableContent.includes(
'2024-us-presidential-election-banner',
Expand All @@ -30,6 +30,7 @@ const EmbedHtml = ({ embeddableContent }: PropsWithChildren<Props>) => {
styles.embedDiv,
isUSElectionBanner && styles.electionBannerOverrides,
]}
className="embed"
suppressHydrationWarning
// eslint-disable-next-line react/no-danger
dangerouslySetInnerHTML={{ __html: embeddableContent }}
Expand Down
8 changes: 6 additions & 2 deletions src/app/pages/ArticlePage/ArticlePage.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
css({
backgroundColor: palette.GREY_2,
}),
grid: ({ mq, gridWidths }: Theme) =>

Check failure on line 24 in src/app/pages/ArticlePage/ArticlePage.styles.ts

View workflow job for this annotation

GitHub Actions / cypress-run (22.x) 

'gridWidths' is declared but its value is never read.

Check failure on line 24 in src/app/pages/ArticlePage/ArticlePage.styles.ts

View workflow job for this annotation

GitHub Actions / cypress-run (22.x) 

'gridWidths' is declared but its value is never read.

Check failure on line 24 in src/app/pages/ArticlePage/ArticlePage.styles.ts

View workflow job for this annotation

GitHub Actions / build (22.x) 

'gridWidths' is declared but its value is never read.

Check failure on line 24 in src/app/pages/ArticlePage/ArticlePage.styles.ts

View workflow job for this annotation

GitHub Actions / cypress-run (22.x) 

'gridWidths' is declared but its value is never read.

Check failure on line 24 in src/app/pages/ArticlePage/ArticlePage.styles.ts

View workflow job for this annotation

GitHub Actions / build (22.x) 

'gridWidths' is declared but its value is never read.
css({
maxWidth: `${pixelsToRem(gridWidths[1008])}rem`,
maxWidth: '100%',
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the grid max-width to 100% affects all article pages globally. This may cause layout issues for standard articles that were designed for the constrained width. Consider making this change conditional based on article type or introducing a variant that only applies to VJ scrolly articles.

Suggested change
maxWidth: '100%',
maxWidth: `${gridWidths.default}px`,

Copilot uses AI. Check for mistakes.
margin: '0 auto',
display: 'grid',
gridTemplateColumns: 'repeat(12, 1fr)',
Expand Down Expand Up @@ -81,9 +81,13 @@
gridColumn: '1 / span 12',
paddingBottom: '2rem',
}),
mainContent: ({ palette, spacings, mq }: Theme) =>
mainContent: ({ palette, spacings, mq, gridWidths }: Theme) =>
css({
paddingBottom: `${spacings.TRIPLE}rem`,
'& > *:not(.embed)': {
maxWidth: `${pixelsToRem(gridWidths[1008])}rem`,
margin: '0 auto',
},

// Hide content after Continue Reading button
'[id="continue-reading-button"] ~ *': {
Expand Down
4 changes: 2 additions & 2 deletions src/app/pages/ArticlePage/ArticlePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
import { ServiceContext } from '../../contexts/ServiceContext';
import RelatedContentSection from '../../components/RelatedContentSection';
import Disclaimer from '../../components/Disclaimer';
import SecondaryColumn from './SecondaryColumn';

Check failure on line 73 in src/app/pages/ArticlePage/ArticlePage.tsx

View workflow job for this annotation

GitHub Actions / cypress-run (22.x) 

'SecondaryColumn' is declared but its value is never read.

Check failure on line 73 in src/app/pages/ArticlePage/ArticlePage.tsx

View workflow job for this annotation

GitHub Actions / cypress-run (22.x) 

'SecondaryColumn' is declared but its value is never read.

Check failure on line 73 in src/app/pages/ArticlePage/ArticlePage.tsx

View workflow job for this annotation

GitHub Actions / build (22.x) 

'SecondaryColumn' is declared but its value is never read.

Check failure on line 73 in src/app/pages/ArticlePage/ArticlePage.tsx

View workflow job for this annotation

GitHub Actions / cypress-run (22.x) 

'SecondaryColumn' is declared but its value is never read.

Check failure on line 73 in src/app/pages/ArticlePage/ArticlePage.tsx

View workflow job for this annotation

GitHub Actions / build (22.x) 

'SecondaryColumn' is declared but its value is never read.
import styles from './ArticlePage.styles';
import { ComponentToRenderProps, TimeStampProps } from './types';
import ContinueReadingButton, {
Expand Down Expand Up @@ -444,7 +444,7 @@
)}
<ElectionBanner aboutTags={aboutTags} taggings={taggings} />
<div css={styles.grid}>
<div css={!isPGL ? styles.primaryColumn : styles.pglColumn}>
<div css={styles.pglColumn}>
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional logic for isPGL has been removed, forcing all articles to use the PGL column layout. This removes the ability to render articles in the standard column width. Consider whether this change should apply to all articles or only specific ones (e.g., those containing VJ scrolly components). If this is intended only for certain articles, restore the conditional logic.

Copilot uses AI. Check for mistakes.
<main css={styles.mainContent} role="main">
<Blocks
blocks={articleBlocks}
Expand Down Expand Up @@ -481,7 +481,7 @@
</div>
</div>
</div>
{!isApp && !isPGL && <SecondaryColumn pageData={pageData} />}
{/* {!isApp && !isPGL && <SecondaryColumn pageData={pageData} />} */}
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SecondaryColumn has been commented out rather than removed. If this is a permanent change, remove the commented code. If this is temporary for testing, add a comment explaining why it's commented out and when it should be restored.

Copilot uses AI. Check for mistakes.
</div>

{/* // EXPERIMENT: Referrer Experiment
Expand Down
Loading