Add DevilutionX (Diablo 1)

[glebm]

Internal controller support is still missing but can be added in a follow-up PR, once @ordovice has extracted a function from CEMU that will make this trivial.

https://github.com/diasurgical/devilutionX

[rtissera]

That's looking good.
You need to patch the engine in order to read from :
/userdata/roms/devilution
instead of
~/.local/share/diasurgical/devilution/

Either using a patch file to C code, either in mk with sed

[Darknior]

Thanks a lot for this new PORT game <3
We miss a lot of them ... really wish you will add some other ...
Like Solarus, Mario War, GZDoom ...

[glebm]

@rtissera I'd rather not patch the code. The data directory can be specified via a command-line argument. How do I pass a command-line argument?

[nadenislamarre]

nice.
a configgen is missing to tell how to call the program (and to add arguments) and configure the pads
(and configure paths : /userdata/system/config/devilutionx for config files)

a very basic configgen :
https://github.com/batocera-linux/batocera.linux/blob/master/package/batocera/core/batocera-configgen/configgen/configgen/generators/pygame/pygameGenerator.py

and in the directory above, you'll find all of them.

a general rules is to respect :
/userdata/system/config/devilutionx : config files
/userdata/roms/devilutionx : roms files
/userdata/saves/devilutionx : saves

in case a user want to reset the config, he have just to remove /userdata/system/config/devilutionx

[glebm]

Thanks for the example, I've added a configgen file.

Still can't test it because the buildroot odroidgoa build is failing:

• Kernel and u-boot failed to build. Fixed in odroidgoA build fixes #2514.

• Patch board/batocera/rockchip/patches/mupen64plus-core/mupen-core-mrfixit-updates.patch fails to apply. Worked around by removing this patch file.

• When building libretro-vecx:

  ./libretro-common/include/glsym/rglgen_private_headers.h:67:10: fatal error: GL/gl.h: No such file or directory

  Sent libretro-vecx: Fix OpenGL dependency #2528

• When building vice:

  LC_ALL=C no -Dplatformall -o vicetmp.txt --no-validate --no-headers ./vice.texi
  /bin/bash: no: command not found
  

  Fixed by installing texinfo (sudo apt install texinfo). The "no" was coming from $(MAKEINFO) in the autotools-generated Makefile.

[glebm]

Current status: shows up in the menu, loads, but does not respond to controller inputs on my RG351p.
External controller does work

[glebm]

Thanks to @ordovice I've figured out what the next steps are to add built-in controller support

[glebm]

@ordovice will extract a function from CEMU that will make adding internal controller support here trivial. Can be done in a follow-up PR.

This should be good to merge now

[rtissera]

Merged.
Let's see how builds go on various platforms, you're welcome to make a follow-up PR with configgen.