Skip to content

Object API#8

Open
brettz9 wants to merge 5 commits into
bat-tomr:masterfrom
brettz9:object-api
Open

Object API#8
brettz9 wants to merge 5 commits into
bat-tomr:masterfrom
brettz9:object-api

Conversation

@brettz9

@brettz9 brettz9 commented May 23, 2019

Copy link
Copy Markdown

If you really need older Node support, I can add Babel...

Are you still maintaining, @bat-tomr ?

brettz9 added 2 commits May 20, 2019 14:49
@brettz9
- Fix: Avoid global cb
4b565bc 
- Enhancement: Promise return option
- Enhancement: Default to timeout of 0
- Optimization: Add `use strict` directive
- Docs: Syntax highlight example
- npm: Fix: `license` and add recommended `contributors` property
@brettz9
Add and use automator workflow for date picker
803a9f8
@ccc-tomr

ccc-tomr commented May 23, 2019 via email

Copy link
Copy Markdown
Collaborator

@brettz9

brettz9 commented May 23, 2019

Copy link
Copy Markdown
Author

Great, thanks... I added another commit refactoring a little bit further...

I'd also find it ideal to add some ESLint rules to force lines such as this:

question ( message, title, timeout, callback){

...to either consistently enforce a space at the beginning and not at the end, or use what seems to be the much more common convention of the following (including the space between the bracket):

question (message, title, timeout, callback) {

I'd also like to enforce consistent brace style. I can enforce https://eslint.org/docs/rules/brace-style#stroustrup style if you wish, though https://eslint.org/docs/rules/brace-style#1tbs is the default and seems most common.

I could also add an ESLint config to catch more errors or styling inconsistencies than eslint:recommended does, e.g., "standard", "airbnb", or my own "ash-nazg", though if so, it'd be nice to know your styling preferences for the above, so I know whether to enforce their styling rules or use the config but override with your styling preference for the above.

@brettz9 brettz9 force-pushed the object-api branch 2 times, most recently from 6870259 to c301ee4 Compare May 23, 2019 23:52
@ccc-tomr

ccc-tomr commented Jul 8, 2019

Copy link
Copy Markdown
Collaborator

Hi Brettz9, on which OSs did you test your changes ? Let me know what couldn't test and I will test it before pulling the request into master

@brettz9

brettz9 commented Jul 9, 2019

Copy link
Copy Markdown
Author

I only tested on Mac OS X (Mojave).

obando777 and others added 2 commits July 25, 2019 14:16
@obando777 @brettz9
- Using osascript -l javascript to retrive a proper filepath not an a…
45c966e 
…lias on Mac

- .gitignore
@brettz9
- Breaking change: Use minimum supported Node version (8.0.0), allowi…
e424735 
…ng us to use `let`, destructuring, etc. without Babel

- Enhancement: Object API
- Linting: Add ESLint (recommended), disabling a style rule
- Refactoring: Prefer `const`; fix global in test file, use strict
@brettz9
- Refactoring: Simplify array pushes to multi-item pushes; use ES6 te…
a271abc 
…mplates for string interpolation, avoiding apparently unneeded (and useless-as-single-backslashes anyways) escapes of double-quotes

- No longer need to disable "no-useless-escape" rule
- npm: Rename `eslint` rule (distinguish from any other linting)
@brettz9 brettz9 mentioned this pull request Aug 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettz9 @ccc-tomr @obando777