Fix boolean received error in getFileInfo()#755
Merged
Sebbo94BY merged 1 commit intoMay 10, 2026
Conversation
The change is in `src/PhpImap/IncomingMailAttachment.php:132: getFileInfo()` now routes the finfo lookup through a small helper and returns `''` if detection fails instead of propagating false into a string return type. I also added `tests/unit/IncomingMailAttachmentTest.php:1` with one regression test for the failure branch and one sanity check for the normal branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is in
src/PhpImap/IncomingMailAttachment.php:132: getFileInfo()now routes the finfo lookup through a small helper and returns''if detection fails instead of propagating false into a string return type. I also addedtests/unit/IncomingMailAttachmentTest.php:1with one regression test for the failure branch and one sanity check for the normal branch.Solves #734