Harden pagination count SQL generation against JSqlParser silent truncation#7085
Draft
Copilot wants to merge 2 commits into
Draft
Harden pagination count SQL generation against JSqlParser silent truncation#7085Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
3 tasks
Copilot
AI
changed the title
[WIP] Fix countSql truncation issue in pagination plugin
Harden pagination count SQL generation against JSqlParser silent truncation
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaginationInnerInterceptor.autoCountSqlcan receive a silently truncated AST from JSqlParser (error-recovery path), producing optimized count SQL that drops?placeholders while MyBatis parameter mappings remain unchanged. This causes runtime parameter-index errors on count queries for complex nestedWHEREclauses.Fallback guard for placeholder integrity
SELECT COUNT(*) FROM (originalSql) TOTAL) instead of returning unsafe optimized SQL.Applied consistently across parser variants
mybatis-plus-jsqlparsermybatis-plus-jsqlparser-4.9mybatis-plus-jsqlparser-5.0Regression coverage for nested-condition scenario
PaginationInnerInterceptorTestclasses to assert placeholder count is preserved for complex nestedWHEREexpressions with multiple bind parameters.