Skip to content

sofa-pbrpc cookie#81

Open
zd-double wants to merge 14 commits into
baidu:masterfrom
zd-double:baidu-branch
Open

sofa-pbrpc cookie#81
zd-double wants to merge 14 commits into
baidu:masterfrom
zd-double:baidu-branch

Conversation

@zd-double

Copy link
Copy Markdown
Collaborator

No description provided.

@cyshi

cyshi commented Mar 28, 2016

Copy link
Copy Markdown
Collaborator

plugin不要放到sample中 用户无法使用 按照之前zuoyan建议 最好增加lite版和full版的rpc库

Comment thread src/sofa/pbrpc/binary_rpc_request.cc Outdated
header.message_size = header.meta_size + header.data_size;

std::string response_attach_str = cntl->GetResponseAttachBuffer()->ToString();
size_t attach_size = response_attach_str.size();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑下兼容性

@cyshi

cyshi commented Apr 8, 2016

Copy link
Copy Markdown
Collaborator

冲突了

@qinzuoyan

Copy link
Copy Markdown
Collaborator

merge一下吧

Comment thread src/sofa/pbrpc/buffer.cc Outdated
}
}

char* ReadBuffer::CurrentHandle()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个接口是否有必要

Comment thread src/sofa/pbrpc/serialize.cc Outdated
} // namespace io
} // namespace sofa

void sofa_touch_sofa_io_serializer()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

touch函数多余

@zd-double

Copy link
Copy Markdown
Collaborator Author

@qinzuoyan 辛苦左言看下还有问题吗?是否可以merge,多谢哈!

@qinzuoyan

Copy link
Copy Markdown
Collaborator

好,辛苦,我找时间看看

@cyshi

cyshi commented Jan 23, 2017

Copy link
Copy Markdown
Collaborator

这个没问题的话 就合入了? @qinzuoyan @bluebore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants