Fix NULL pointer dereference in ResolveAddress()#251
Closed
hirorogo wants to merge 1 commit into
Closed
Conversation
Both overloads of ResolveAddress() accept an RpcEndpoint* endpoint parameter but dereference it unconditionally without checking for NULL. Add NULL validation with error logging before any dereference, returning false early if endpoint is NULL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Closing in favor of #252 which has a cleaner diff. Same fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both overloads of
ResolveAddress()insrc/sofa/pbrpc/rpc_endpoint.ccaccept anRpcEndpoint* endpointparameter but dereference it unconditionally (*endpoint = it->endpoint()) without checking for NULL. Added NULL validation with error logging, returningfalseearly ifendpointis NULL.PoC
Output (MSVC
/EHa):Test plan
ResolveAddress()with NULL endpoint returnsfalseinstead of crashing