Repository navigation
Set upstream URL - #282
Open
Regenhardt wants to merge 2 commits into
Open
Set upstream URL#282Regenhardt wants to merge 2 commits into
Regenhardt wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the upstream URL and also adds that information to the GUI.
The initial implementation added reading the service URL, but only set it in the test constructor, not the one actually used at runtime.
The implementation to read it keeps the search interface stable for now. It subclasses the search result in order to keep the search result in sync with nuget too. The result builder then constructs the extended class, which the GUI pattern matches on. Not sure this is the way, or if the interface should actually return the extended model, which would break possibly existing different implementation of the BaGetter core interfaces.