Conversation
size-limit report 📦
|
|
👋 As I understand the lint report the contract size but is there an actual limit set somewhere? |
Yes. See: #2 for more informations. |
| uses: davidB/rust-cargo-make@v1 | ||
|
|
||
| - name: Test rust code | ||
| run: cargo make check_contracts |
There was a problem hiding this comment.
check_contract task is no longer called from the CI, is the desired behavior ?
There was a problem hiding this comment.
🤔 Nope. But it should be part of the linter workflow I guess...
| "devDependencies": { | ||
| "@size-limit/preset-app": "^7.0.8" | ||
| }, | ||
| "size-limit": [ |
There was a problem hiding this comment.
To do in another PR, but this configuration (size-limit) can be removed now from the package.json and use the .size-limit configuration file (available in main branch for the CI now).
There was a problem hiding this comment.
Sure. Could be please push a new PR with the needed changes? Thanks. 😌
|
@bdeneux There's still an issue on the branch
|
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
7 participants
Fix the CI break (+ some minor improvements).