Do not crash the client if ingestion server is down#164
Open
vizath wants to merge 1 commit intoaxiomhq:mainfrom
Open
Do not crash the client if ingestion server is down#164vizath wants to merge 1 commit intoaxiomhq:mainfrom
vizath wants to merge 1 commit intoaxiomhq:mainfrom
Conversation
Author
|
Any wish to have this reviewed? Axiom ingestion was down again last night between 2:28am UTC - 3:20am UTC, propagating the downtime to our endpoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we had received a few 503 from axiom logging.
When the Client receives a 503 after few retries, it raise an Exception.
That's problematic because it also crashes the whole app.
How to reproduce in a production python app:
axiom_py.Client(token=token, url_base="https://httpstat.us/503")Another solution would be to move the try/except in the flush function of
logging.py.I'm not super fluent in python, feel free to propose changes.
Some related stack trace: