Skip to content

Security: Logical ID uniqueness check can be bypassed via substring matching #3911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −1
Open

Security: Logical ID uniqueness check can be bypassed via substring matching #3911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion samtranslator/translator/verify_logical_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,10 @@ def verify_unique_logical_id(resource: Resource, existing_resources: dict[str, A
# new resource logicalid is in the do_not_resolve list
return bool(
resource.resource_type in do_not_verify
and existing_resources[resource.logical_id]["Type"] in do_not_verify[resource.resource_type]
and existing_resources[resource.logical_id]["Type"]
in (
do_not_verify[resource.resource_type]
if isinstance(do_not_verify[resource.resource_type], list)
else [do_not_verify[resource.resource_type]]
)
)
Loading