Skip to content

perf: use list join instead of string concatenation in loop #3829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshatsinha0 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

perf: use list join instead of string concatenation in loop #3829

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75cbff8
perf: use list join instead of string concatenation in loop
akshatsinha0 Oct 16, 2025
b944a5f
refactor: addressing comment removals
akshatsinha0 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions samtranslator/translator/translator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,15 @@ def _get_function_names(
)
if not resolved_function_name:
continue
self.function_names.setdefault(api_name, "")
self.function_names[api_name] += str(resolved_function_name)
return self.function_names
# OLD APPROACH: String concatenation in loop
# self.function_names.setdefault(api_name, "")
# self.function_names[api_name] += str(resolved_function_name)
# NEW APPROACH: Collect in list
Copy link
Copy Markdown
Contributor

@reedham-aws reedham-aws Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need the comment with the old approach.

if api_name not in self.function_names:
self.function_names[api_name]=[]
Copy link
Copy Markdown
Contributor

@reedham-aws reedham-aws Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if api_name not in self.function_names:
self.function_names[api_name]=[]
self.function_names.setdefault(api_name, [])

self.function_names[api_name].append(str(resolved_function_name))
#backward compatibility
Copy link
Copy Markdown
Contributor

@reedham-aws reedham-aws Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is also probably unnecessary.

Copy link
Copy Markdown
Author

@akshatsinha0 akshatsinha0 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okayy

return {api: "".join(names) for api, names in self.function_names.items()}

def translate( # noqa: PLR0912, PLR0915
self,
Expand All @@ -127,7 +133,9 @@ def translate( # noqa: PLR0912, PLR0915
self.feature_toggle = feature_toggle or FeatureToggle(
FeatureToggleDefaultConfigProvider(), stage=None, account_id=None, region=None
)
self.function_names: Dict[Any, Any] = {}
# OLD: self.function_names: Dict[Any, Any] = {}
# NEW: Use List[str] for efficient accumulation, convert to str when needed
Copy link
Copy Markdown
Contributor

@reedham-aws reedham-aws Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion on commenting the old approach.

self.function_names: Dict[str, List[str]] = {}
self.redeploy_restapi_parameters = {}
sam_parameter_values = SamParameterValues(parameter_values)
sam_parameter_values.add_default_parameter_values(sam_template)
Expand Down
Loading