Repository navigation
Build etcd with Go 1.26 on all release branches - #5034
Merged
Merged
Conversation
The etcd build takes its Go version from the latest dev release artifacts and raises it to a floor. The floor was 1.24 for 1-31 through 1-35 and 1.25 for 1-36 and 1-37, so every current release builds etcd with go1.25.13. Go 1.25 no longer receives upstream security fixes, including the crypto/x509 change that distrusts the compromised eMudhra intermediates (CVE-2026-111943), which is in go1.26.10 and go1.27.3. Raise the floor to 1.26 for every release branch. A source version of 1.27 or later is still used as-is. etcd v3.5.21 and v3.6.12 (server and etcdctl) both build with go1.26.10, report "Go Version: go1.26.10", and pass a single-node put/get and endpoint health check. The per-branch GOLANG_VERSION files are not read by the etcd build, so they are unchanged.
Member
|
/lgtm |
Member
Author
|
/approve |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nihalnurs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The etcd build reads its Go version from the latest dev release artifacts and raises it to a minimum (1.24 for 1-31 to 1-35, 1.25 for 1-36 and 1-37), so current releases build etcd with go1.25.13. Go 1.25 no longer receives upstream security fixes, including the crypto/x509 fix for CVE-2026-111943 in go1.26.10 and go1.27.3. This raises the minimum to 1.26 on every release branch. A source version of 1.27 or later is still used as-is.
The per-branch
GOLANG_VERSIONfiles are not read by the etcd build, so they are unchanged.Testing:
Go Version: go1.26.10, and pass a single-node put/get and endpoint health check.The etcd
ATTRIBUTION.txtfiles still list go1.25.13 and will be refreshed by the PR bot after merge.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.