fix(memory): add explicit pass-through methods to MemoryClient for IDE autocomplete#553
Open
citizen204 wants to merge 1 commit into
Open
Conversation
…E autocomplete Fixes aws#354
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
citizen204
requested a deployment
to
manual-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MemoryClientuses__getattr__to proxy 15 boto3 client methods. Static analysis tools in IDEs cannot see through__getattr__, so none of those methods appeared in autocompletion, hover docs, or type-checker diagnostics.This PR adds 15 explicit forwarding methods — 13 data-plane (
gmdp_client) and 2 control-plane (gmcp_client) — that delegate to the sameaccept_snake_case_kwargs-wrapped boto3 calls that__getattr__already uses. Runtime behavior is unchanged;__getattr__is kept as a catch-all for any future additions.Fixes #354
Changes
src/bedrock_agentcore/memory/client.py: Added explicit methods forretrieve_memory_records,get_memory_record,delete_memory_record,list_memory_records,get_event,delete_event,batch_create_memory_records,batch_delete_memory_records,batch_update_memory_records,start_memory_extraction_job,list_memory_extraction_jobs,list_sessions,list_actors(data plane) andget_memory,update_memory(control plane).