Repository navigation
docs(otel): define supported sampling modes - #852
Open
zhongkechen wants to merge 1 commit into
Open
zhongkechen wants to merge 1 commit into
zhongkechen wants to merge 1 commit into
Conversation
zhongkechen
temporarily deployed
to
ai-pr-review-runtime
October 30, 2026 19:04 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Related to aws/aws-durable-execution-docs#295.
Shared guide: aws/aws-durable-execution-docs#304. Merge the guide first so the common supported-sampling link resolves.
Description
The sampling documentation describes decision reuse without clearly separating supported local policies from policies that can change across reinvocations. Clarify that an authoritative upstream
Sampled=0/1takes precedence; without that decision, local sampling must be deterministic for a stable canonical trace ID and unchanged configuration. Document constant and fixed-ratio policies, and explain that the process-local cache does not make changing policies supported or persist decisions across execution environments.Preserve Java's same-trace ambient precedence and its provider-specific limitations. No runtime behavior, public API, or tests change.
Demo/Screenshots
Not applicable. Rendered the updated Markdown and inspected the sampling section and links.
Design
Assumptions
Existing precedence and delegation are verified against
OtelPluginSupport.resolveSamplingResult,DurableSampler.shouldSample, and the explicit-sampling tests inDurableSamplerTest. The shared guide anchor is introduced by the linked guide PR.Decisions not covered by the issue or the design note
Keep provider compatibility caveats separate from policy support: plain replacements do not provide SDK-wide sampling guarantees, without declaring those configurations unsupported.
Checklist
Testing
git diff --checkpassed. Markdown rendering confirmed four precedence entries and the shared-guide link. Repository-widemvn -o -B -q spotless:check --file pom.xmlpassed with JDK 17.Unit Tests
Not added or run; documentation only.
Integration Tests
Not added or run; documentation only.
Examples
Documented supported Java sampler choices and explicit upstream overrides; no executable examples added.