[v2] Auto-detect account regional namespace buckets in s3 mb#10212
Open
AndrewAsseily wants to merge 7 commits intov2from
Open
[v2] Auto-detect account regional namespace buckets in s3 mb#10212AndrewAsseily wants to merge 7 commits intov2from
AndrewAsseily wants to merge 7 commits intov2from
Conversation
…tNamespace header
aemous
requested changes
Apr 16, 2026
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
Left some comments.
Also, consider adding ~1 integration test. We are making some assumption on server behavior so it may be worth baking that into tests. Such as, attempt to create a bucket with name xyz-an, and expect s3 to return an error that the formatting is wrong.
aemous
previously approved these changes
Apr 20, 2026
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
LGTM.
I approve merge assuming all CI pass. At least 1 new integ test may be added before merge as long as they have been tested.
AndrewAsseily
changed the title
aemous
previously approved these changes
Apr 20, 2026
Contributor
aemous
left a comment
aemous
left a comment
There was a problem hiding this comment.
LGTM assuming CI passes and the new integ test was tested.
🏆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The s3 mb command now automatically detects account regional namespace bucket names (matching *---an) and sets the x-amz-bucket-namespace: account-regional header on the CreateBucket request. Previously, users had to fall back to s3api create-bucket --bucket-namespace for
this workflow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.