Improving caching of S3 endpoints by omitting unused parameters#10165
Merged
Improving caching of S3 endpoints by omitting unused parameters#10165
Conversation
ashovlin
force-pushed
the
skip-unused-s3-params
branch
from
6ba2a46 to
3a27dc2
Compare
ashovlin
force-pushed
the
skip-unused-s3-params
branch
from
55c2534 to
513dc77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: CLI-8066, variation of boto/botocore#3529
Description of changes: When resolving the endpoint for S3 operations, currently
{'Key', 'Prefix', 'CopySource'}are defined as parameters in S3's rules, but aren't currently referenced. This is an issue for endpoint caching, since objects in the same bucket result in a unique set of endpoint parameters. So when runningsyncorcp -rfor lots of objects in the same bucket, we need to recalculate the endpoint each object.Now, we drop these three parameters specifically before passing them into the rules. This comes with a test that will begin failing when the rules start referencing these parameters (or add new, unused parameters).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.