Repository navigation
Conversation
… ownership to plugin manager
yanw-bq
force-pushed
the
feat/full-service-container
branch
from
October 28, 2026 21:08
71edc2a to
d7ea556
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a FullServiceContainer to every connection handle (DBC), holding the services the connection uses, and move ownership of the plugin chain from PluginService to a new PluginManager
Description
driver/util/full_service_container.{h,cpp}): one per DBC, created with the DBC (DBC::service_container).StorageService&andMonitorService&, retrieved fromCoreService::Instance().PluginServiceandPluginManager, created on the first connect byInitConnectionServices(). They need the connection attributes, and are kept acrossSQLDisconnectand reused on reconnect, the same as before. The PluginManager is only stored once its chain has built, so a chain that fails to build is retried on the next connect.InitMonitoringServices()creates the PluginService and the reduced plugin chain for the DBC a monitor opens its connections from.driver/util/plugin_manager.{h,cpp}): owns the plugin chain and is the entry point for calls into it (Connect,Execute,ReleaseResources).GetPluginChain()is for the code that keeps the chain's head.DBC::plugin_service,DBC::plugin_head,PluginService::plugin_chain_andPluginService::Get/SetPluginChain(). Access to the PluginService now goes through the container.Build(dbc)holds the chain construction moved out ofRDS_InitializeConnection, unchanged: same plugins, order and errors.MonitoringBuild(dbc)no longer takes or sets the PluginService.odbcapi_rds_helper.cppno longer includes the plugin headers.SQLDisconnect,SQLExecute,SQLExecDirect, connect, connection free, the failover reconnect and the blue/green substitute connect routing go through PluginManager.InitMonitoringServices().RdsHostListProvider,ClusterTopologyMonitor,BlueGreenStatusProviderandBlueGreenMonitortake the monitor'sstd::shared_ptr<FullServiceContainer>instead of a PluginService.plugin_head == nullptr.Testing
full_service_container_test.cpp