Repository navigation
refactor: cache return std::optional - #166
Merged
Merged
Conversation
yanw-bq
reviewed
Oct 8, 2026
yanw-bq
reviewed
Oct 8, 2026
ColinKYuen
marked this pull request as ready for review
October 21, 2026 01:40
yanw-bq
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caches return std::optional
Description
Changed caches to return with std::optional to differentiate between default constructed values and truly non-existent value
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.