ci: Use windows-2025 runner for Windows CI build - #1806
Open
muboheng wants to merge 1 commit into
Open
Conversation
Pin the Windows leg of the Java CI matrix to windows-2025 instead of windows-latest. Makes the runner OS deterministic as GitHub migrates windows-latest to Server 2025, and validates the build on the OS customers now run. Server 2025 removed WMIC.exe by default, but nucleus is unaffected: its Windows process management uses taskkill and java.lang.Process APIs, and it never invokes zt-process-killer's WMIC-based isAlive().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin the Windows leg of the Java CI matrix (
.github/workflows/maven.yml) towindows-2025instead ofwindows-latest.Why
windows-latestfrom Server 2022 to Server 2025; pinning explicitly avoids the runner shifting underneath the build mid-migration.WMIC.exe note (safety check)
Windows Server 2025 removed
WMIC.exeby default, which can break Java tooling that shells out to it (e.g.zt-process-killer'sWindowsProcess.isAlive()). Nucleus was checked and is not affected:WindowsPlatform,WindowsExec) usestaskkillandjava.lang.ProcessAPIs.zt-process-killer'sdestroy()(which usestaskkill), neverisAlive()(the WMIC path).wmic/Wbem; tests use JVM-nativePidUtil/pgrep.So the WMIC code path is dead code in nucleus's usage, and the
mvn verifyWindows build is expected to pass onwindows-2025.