Repository navigation
Conversation
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
…d draft-skip Amazon's ubuntu-latest runners draw on a single enterprise-wide shared concurrency pool. Apply the org-recommended CI hygiene practices to the PR-triggered workflows, matching the fix landed on aws-deadline/deadline-cloud. - Add a P2-correct concurrency block to code_quality, security_scan, codeql, record_pr, and auto_approve. The group key uses a conditional suffix so PR events share a per-ref group (supersede-cancel works) while non-PR events (push/schedule/workflow_call) get a unique run_id and are never cancelled by a shared pending run. - Draft-skip the heavy code_quality Test matrix via a ready_for_review trigger type plus an if-guard. workflow_call has no PR context, so the job still runs for release/manual-release callers. - Set explicit fail-fast: true on the code_quality matrix. - Leave codeql and security_scan without draft-skip since they are required status checks. Purely additive; no existing logic removed. Signed-off-by: kavmur <kavmur@users.noreply.github.com>
kavmur
force-pushed
the
ci/github-actions-hygiene
branch
from
October 9, 2026 22:16
00f6eae to
1578dda
Compare
Contributor
|
Some Code Quality workflows are failing. Could you take a look? |
Author
Looks like a mypy failure unrelated to this PR. Likely caused by new mypy 2.4.0 update |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
PR-triggered CI workflows had no
concurrencyblock, so superseded runs on a branch kept running and new pushes queued extra jobs on the shared enterpriseubuntu-latestpool. With agent-driven development pushing frequently per PR, this wastes runner capacity on a pool that degrades silently under load.What was the solution? (How)
Applied the org admins' recommended GitHub Actions hygiene practices to the PR CI workflows (
code_quality.yml, codeql.yml, security_scan.yml, record_pr.yml, auto_approve.yml), purely additive:pull_requestevents share a per-ref group so a new push supersedes the in-progress run; all other events (push/release/workflow_call) get a uniquegithub.run_idsuffix so they never cancel each other's pending runs.ready_for_reviewtrigger +if: github.event.pull_request.draft != true). Not applied tocodeql/security_scanso those keep reporting.fail-faston thecode_qualitymatrix.What is the impact of this change?
Lower consumption of the shared Actions runner pool, especially on draft PRs and rapid push bursts. No change to what the jobs do. Verified: not a required status check —
mainlineonly requiresSemantic PRandDCO, so skipping these jobs on drafts cannot stall the merge queue.How was this change tested?
Statically validated — every edited workflow parses cleanly with
yaml.safe_loadand the concurrency/if guards were confirmed structurally. Runtime behavior (cancel-on-push, draft-skip) manifests only on GitHub's runners; recommend opening as a draft first to confirm the heavy jobs skip, then marking ready.Integ test result
N/A — CI configuration only; no
src/changes.Installer test result
N/A — no
installer/orsrc/changes.Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
N/A — change is limited to
.github/workflows/; no submitter or adaptor code touched.Was this change documented?
No doc changes needed — workflow-config only.
Did you modify schema files?
Is this a breaking change?
No. Draft-skip (Yes —
code_quality.yml's matrix build skips draft PRs and sets explicitfail-fast.) Additive workflow metadata only; no public contract or adaptor interface changed.