Skip to content

ci: enable installer XML reminder - #487

Open
karthikbekalp wants to merge 1 commit into
aws-deadline:mainlinefrom
karthikbekalp:ci/installer-xml-reminder
Open

karthikbekalp wants to merge 1 commit into
aws-deadline:mainlinefrom
karthikbekalp:ci/installer-xml-reminder

Conversation

@karthikbekalp

@karthikbekalp karthikbekalp commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Depends on: aws-deadline/.github#109. Merge that PR first so the shared workflow is available on mainline.

What was the problem/requirement? (What/Why)

Some changes in individual submitter installers were missing from the shared installer. Authors need a reminder to review matching updates.

What was the solution? (How)

Add .github/workflows/installer_xml_check.yml to call the shared Python check. It flags XML changes under installer/ or install_builder/ and lists the changed files in the log.

What is the impact of this change?

This submitter is included in the shared installer. The check runs on PRs, including drafts. When it flags a change, review whether the shared installer needs an update and confirm any follow-up in the PR discussion. Keep private details and links out of public discussions.

How was this change tested?

  • The caller workflow passed actionlint and zizmor validation.
  • The shared checker was tested in this Cinema 4D Actions run: an XML edit produced the expected reminder and failed check.
  • Application tests were not run for this workflow-only change.

Was this change documented?

Setup and follow-up are documented in installer-xml-changes.md in the shared workflow PR.

Did you modify schema files?

  • Yes
  • No

Is this a breaking change?

No.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Claude review · advisory

Reviewed dd205b6 (full review): 0 findings.

Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking.

Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed.

@karthikbekalp
karthikbekalp marked this pull request as ready for review October 8, 2026 15:53
@karthikbekalp
karthikbekalp requested a review from a team as a code owner October 8, 2026 15:53

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants