Repository navigation
ci: enable installer XML reminder - #487
Open
karthikbekalp wants to merge 1 commit into
Open
karthikbekalp wants to merge 1 commit into
karthikbekalp wants to merge 1 commit into
Conversation
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
crowecawcaw
approved these changes
Oct 8, 2026
karthikbekalp
marked this pull request as ready for review
October 8, 2026 15:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: aws-deadline/.github#109. Merge that PR first so the shared workflow is available on
mainline.What was the problem/requirement? (What/Why)
Some changes in individual submitter installers were missing from the shared installer. Authors need a reminder to review matching updates.
What was the solution? (How)
Add
.github/workflows/installer_xml_check.ymlto call the shared Python check. It flags XML changes underinstaller/orinstall_builder/and lists the changed files in the log.What is the impact of this change?
This submitter is included in the shared installer. The check runs on PRs, including drafts. When it flags a change, review whether the shared installer needs an update and confirm any follow-up in the PR discussion. Keep private details and links out of public discussions.
How was this change tested?
Was this change documented?
Setup and follow-up are documented in
installer-xml-changes.mdin the shared workflow PR.Did you modify schema files?
Is this a breaking change?
No.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.