Repository navigation
ci: check shared installer coordination on PRs - #486
Closed
karthikbekalp wants to merge 1 commit into
Closed
karthikbekalp wants to merge 1 commit into
karthikbekalp wants to merge 1 commit into
Conversation
Signed-off-by: Karthik BekalPattathana <133984042+karthikbekalp@users.noreply.github.com>
github-actions
Bot
added
the
waiting-on-maintainers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Installer definition changes need explicit confirmation that any corresponding shared Deadline Cloud submitter installer follow-up is handled.
What was the solution? (How)
Call the central static checker from trusted PR events and PR conversation comment events. For XML definition changes under
installer/orinstall_builder/, it creates or updates one bot comment and accepts/installer-followup done,/installer-followup in-review, or/installer-followup not-neededfrom the PR author or a maintainer. Unrelated PRs pass without a question.What is the impact of this change?
The dedicated
Installer coordinationstatus fails until a valid confirmation is present. Replies, edits, and deletions update that status on the PR's current head commit. The workflow checks out only trusted central tooling and never executes PR code. The question and its status use fixed public wording without requesting or echoing non-public details, review identifiers, or tracking links.Depends on aws-deadline/.github#108. Merge the shared workflow first. After this caller runs, configure the
Installer coordinationcommit status as required formainlineto enforce confirmation before merge.How was this change tested?
Actionlint and zizmor validation for this caller. The shared checker passes all 88 Python 3.13 unit tests, including 30 new tests covering detection, authorised commands, comment reuse, reply edits/deletions, fork-head status updates, and API/posting failures.
Was this change documented?
The shared setup guide documents the commands, event handling, permissions, and required-status setup. The bot comment provides the author-facing instructions; no PR-template checkbox is needed.
Is this a breaking change?
No public package or installer interface changes. The new status can be configured as a required contributor check.