Skip to content

fix(ci): quote HATCH_UV so pre-install works when hatch lives under a… - #309

Merged
wyongzhi merged 1 commit into
aws-deadline:mainlinefrom
wyongzhi:fix/ci-hatch-uv-quote
Oct 26, 2026
Merged

wyongzhi merged 1 commit into
aws-deadline:mainlinefrom
wyongzhi:fix/ci-hatch-uv-quote

Conversation

@wyongzhi

Copy link
Copy Markdown
Contributor

What was the problem/requirement? (What/Why)

#308 switched hatch.toml to {env:HATCH_UV} pip install .... On the integ CodeBuild runner hatch is installed under C:\Program Files\Python313, so the expansion is an unquoted path with a space and cmd runs C:\Program:

pre-install [1] | C:\Program Files\Python313\Scripts\uv.EXE pip install -r requirements-integ-testing.txt
'C:\Program' is not recognized as an internal or external command

hatch run integ-ci:setup fails before any test runs (3ds Max Integration Tests run #61).

What was the solution? (How)

Quote the expansion: "{env:HATCH_UV}" pip install ... in every pre-install-commands and sync entry (default, integ, integ-ci).

What is the impact of this change?

CI only. No source or behaviour change.

How was this change tested?

Reproduced on a Windows machine with hatch installed under C:\Program Files\...: the unquoted form fails with the exact CodeBuild error; the quoted form creates the default and integ-ci.py3.11-2026 envs, pytest resolves from inside the hatch env, and hatch run test passes (483). Verified with both uv-backed (HATCH_ENV_TYPE_VIRTUAL_UV_PATH set) and virtualenv-backed envs.

Then ran the CodeBuild path end to end on that machine: hatch -e integ-ci.py3.11-2026 run test -m adaptor (3ds Max 2026 + V-Ray 7). Env creation and both pre-install commands succeed; 7 passed, 1 xfailed, 3 failed for reasons unrelated to this change (headless session has no GPU for the V-Ray GPU lightmix case; vrmesh_path_remap fails identically on mainline on this machine; batch_render expected images are updated in a separate PR).

On macOS, a uv copy placed in a directory with a space reproduces the same class of failure (/bin/sh: /tmp/dir: No such file) and the quoted form passes; hatch run lint clean.

Was this change documented?

No, CI-internal.

Did you modify schema files?

  • Yes
  • No

Is this a breaking change?

No.

… path with spaces

The integ CodeBuild runner installs hatch under "C:\Program Files\...", so
`{env:HATCH_UV} pip install ...` expanded to an unquoted path and cmd ran
`C:\Program`: "'C:\Program' is not recognized as an internal or external
command". Quote the expansion in every pre-install-commands and sync entry.

Signed-off-by: wyongzhi <276409147+wyongzhi@users.noreply.github.com>
@wyongzhi
wyongzhi requested a review from a team as a code owner October 26, 2026 21:49
@github-actions github-actions Bot added the waiting-on-maintainers Waiting on the maintainers to review. label Oct 26, 2026
@github-actions

Copy link
Copy Markdown

Claude review · advisory

Reviewed 89a8391 (full review): 0 findings.

Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking.

Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed.

@wyongzhi
wyongzhi merged commit 85e834d into aws-deadline:mainline Oct 26, 2026
11 checks passed
@wyongzhi
wyongzhi deleted the fix/ci-hatch-uv-quote branch October 26, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-on-maintainers Waiting on the maintainers to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants