Repository navigation
fix(ci): quote HATCH_UV so pre-install works when hatch lives under a… - #309
Merged
Merged
Conversation
… path with spaces
The integ CodeBuild runner installs hatch under "C:\Program Files\...", so
`{env:HATCH_UV} pip install ...` expanded to an unquoted path and cmd ran
`C:\Program`: "'C:\Program' is not recognized as an internal or external
command". Quote the expansion in every pre-install-commands and sync entry.
Signed-off-by: wyongzhi <276409147+wyongzhi@users.noreply.github.com>
|
Claude review · advisory Reviewed Open: 0 blocking · 0 should-fix · 0 nit. ✅ Nothing blocking. Fix or reply to each thread; the next revision's review re-checks open threads and resolves those it agrees are handled. Resolving a thread yourself also closes it. Later revisions review only what changed. |
leongdl
approved these changes
Oct 26, 2026
godobyte
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
#308 switched hatch.toml to
{env:HATCH_UV} pip install .... On the integ CodeBuild runner hatch is installed underC:\Program Files\Python313, so the expansion is an unquoted path with a space and cmd runsC:\Program:hatch run integ-ci:setupfails before any test runs (3ds Max Integration Tests run #61).What was the solution? (How)
Quote the expansion:
"{env:HATCH_UV}" pip install ...in everypre-install-commandsandsyncentry (default,integ,integ-ci).What is the impact of this change?
CI only. No source or behaviour change.
How was this change tested?
Reproduced on a Windows machine with hatch installed under
C:\Program Files\...: the unquoted form fails with the exact CodeBuild error; the quoted form creates thedefaultandinteg-ci.py3.11-2026envs, pytest resolves from inside the hatch env, andhatch run testpasses (483). Verified with both uv-backed (HATCH_ENV_TYPE_VIRTUAL_UV_PATHset) and virtualenv-backed envs.Then ran the CodeBuild path end to end on that machine:
hatch -e integ-ci.py3.11-2026 run test -m adaptor(3ds Max 2026 + V-Ray 7). Env creation and both pre-install commands succeed; 7 passed, 1 xfailed, 3 failed for reasons unrelated to this change (headless session has no GPU for the V-Ray GPUlightmixcase;vrmesh_path_remapfails identically on mainline on this machine;batch_renderexpected images are updated in a separate PR).On macOS, a uv copy placed in a directory with a space reproduces the same class of failure (
/bin/sh: /tmp/dir: No such file) and the quoted form passes;hatch run lintclean.Was this change documented?
No, CI-internal.
Did you modify schema files?
Is this a breaking change?
No.