Repository navigation
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E3511IAM role ARN rule from the CEL and Rego engines, the rule registry, and the cfn-lint data extractor.AWS::IAM::Role.Nameformat validation asE1165using IAM's role-name and optional-path constraints.anyOffails, so invalid Batch role references reportF3017,E1156, andE1165at the same property.Why
E3511duplicated the schema-backedAWS::IAM::Role.Arnformat rule (E1156) with a hardcoded property list and a different regular expression. It could report the same malformed ARN twice. It also rejected valid role names and path-prefixed role names on the twoAWS::Batch::ComputeEnvironmentproperties that accept either an ARN or a name.The enhanced schemas now express the contract directly:
AWS::Backup::BackupSelectionBackupSelection/IamRoleArnformat: AWS::IAM::Role.ArnAWS::ECS::TaskDefinitionExecutionRoleArnformat: AWS::IAM::Role.ArnAWS::EC2::SpotFleetSpotFleetRequestConfigData/IamFleetRoleformat: AWS::IAM::Role.ArnAWS::S3::BucketReplicationConfiguration/Roleformat: AWS::IAM::Role.ArnAWS::Batch::ComputeEnvironmentServiceRoleanyOf: [Role.Arn, Role.Name]AWS::Batch::ComputeEnvironmentComputeResources/SpotIamFleetRoleanyOf: [Role.Arn, Role.Name]Related work
Validation behavior changes
E3511is removed.E1156.anyOffailure (F3017) and both failed format branches (E1156andE1165), matching cfn-lint's schema reporting.aws-prefixed partition without a fixed partition allowlist.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.