Repository navigation
Create TLEscope icon on Linux and MacOS build - #83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Aria,
I noticed that the TLEscope logo in the repo has been replaced by a generated icon at compile time. However, this was not created for the
linuxandmacosbuild targets so I added them in the makefile.I also changed the
installtarget to avoid re-building as root user. The workflow is nowwhich avoids creating a directory owned by
rootindist. This created problems on a subsequent build without superuser rights.Hope you find these changes useful! All the best!