Skip to content

refactor: extract delegate functions from filesize for better SRP #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avoidwork merged 11 commits into from
Apr 20, 2026
Merged

refactor: extract delegate functions from filesize for better SRP #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4229ca7
refactor: extract delegate functions from filesize for better SRP
avoidwork Apr 19, 2026
d3a6666
docs: improve package.json description
avoidwork Apr 19, 2026
e358874
fix: use isNaN(e) instead of isNaN(exponent) in calculateExponent
avoidwork Apr 20, 2026
c342785
docs: remove misleading EXPO reference from formatOutput JSDoc
avoidwork Apr 20, 2026
06253c3
chore: rebuild dist
avoidwork Apr 20, 2026
945ae88
docs: update AGENTS.md and TECHNICAL_DOCUMENTATION.md for delegate ar…
avoidwork Apr 20, 2026
cdd3363
fix: correct decorateResult/formatOutput types and JSDoc param types
avoidwork Apr 20, 2026
dce2e64
fix: parse result[0] as number before singular/plural check in fullform
avoidwork Apr 20, 2026
43069a0
fix: cover edge cases and fix Infinity/BigInt/partial immutability
avoidwork Apr 20, 2026
ecead4e
refactor: replace ternaries with full conditionals in helpers.js
avoidwork Apr 20, 2026
d2ef0db
chore: build and update coverage
avoidwork Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,18 @@ Input → Validation → Standard Normalization → Exponent Calculation

### Key Components

1. **`filesize(arg, options)`**: Main conversion function
2. **`partial(options)`**: Creates pre-configured function
1. **`filesize(arg, options)`**: Orchestrator — delegates validation, exponent, value calc, rounding, formatting, and output dispatch
2. **`partial(options)`**: Creates pre-configured formatter with immutable frozen options
3. **`handleZeroValue()`**: Special handling for zero input
4. **`calculateOptimizedValue()`**: Core conversion logic
5. **`applyPrecisionHandling()`**: Precision + scientific notation fix
4. **`calculateOptimizedValue()`**: Core conversion logic with bits handling
5. **`applyPrecisionHandling()`**: Precision + scientific notation correction
6. **`applyNumberFormatting()`**: Locale, separator, padding
7. **`getBaseConfiguration()`**: Cached base/standard lookup table
8. **`calculateExponent()`**: Log-based exponent calculation with clamping
9. **`applyRounding()`**: Rounding + auto-increment ceiling adjustment
10. **`resolveSymbol()`**: Symbol table lookup with SI override for e=1
11. **`decorateResult()`**: Negation, custom symbols, full form assembly
12. **`formatOutput()`**: Array/object/string output dispatch

### Standard Selection

Expand Down
Loading
Loading